Add context for the All translatable string and enforce l10n best practices #58196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
afercia
changed the title
|
Size Change: +3.58 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I think I accidentally included an unrelated fix in packages/edit-site/src/components/global-styles/font-library-modal/library-font-card.js but I guess it's not a big deal, it's a valid fix. |
|
Flaky tests detected in b4dbe5a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7641804584
|
carolinan
reviewed
Jan 25, 2024
|
I'd appreciate a quick review, changes in this PR are simple enough Cc @WordPress/gutenberg-core |
Mamaduka
approved these changes
Jan 30, 2024
|
Thanks @Mamaduka 👋 |
MaggieCabrera
added
General Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58185
What?
The
__( 'All' )string needs more context to be correctly translatable.Why?
Languages other htan English may have genres.
How?
_x()function._x()second parameter: must be short and lowercase.Testing Instructions
Not fully appplicable.
I guess a code review is enough in this case.
Testing Instructions for Keyboard
Screenshots or screencast