Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Update the default collection data url to the wordpress.org cdn #58186

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

Update the default collection data URL to the wordpress.org cdn

Why?

Replace the URL from a GitHub URL to the one hosted by the wordpress.org CDN.

How?

Just by replacing the link.

Testing Instructions

Navigate to the Font Library and check that the Google Fonts collection is loading as expected.

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/fonts/font-library/font-library.php

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasbenedetto matiasbenedetto enabled auto-merge (squash) January 24, 2024 13:37
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. URL is pointing to the correct version in the CDN which has been correctly added and is available as I expected.

🚢

@matiasbenedetto matiasbenedetto merged commit 81549ba into trunk Jan 24, 2024
58 of 59 checks passed
@matiasbenedetto matiasbenedetto deleted the update/font-collection-data-url branch January 24, 2024 14:00
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 24, 2024
@mikachan mikachan mentioned this pull request Jan 24, 2024
@getdave getdave added the Needs PHP backport Needs PHP backport to Core label Jan 26, 2024
@getdave
Copy link
Contributor

getdave commented Jan 26, 2024

I noticed this PR was merged after I raised the PHP Sync Tracking Issue for WP 6.5 and has changed PHP files that may need backporting to WP Core.

I believe this will be backported as part of a single backport for the Fonts API. It's been added to the Tracking Issue.

@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Font Library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants