-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Added chunk filename in webpack config to avoid reading stale files #58176
Scripts: Added chunk filename in webpack config to avoid reading stale files #58176
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rithik56! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There CI issues reported, because the webpack config setting added has a typo in it.
Is this branch up to date with changes applied to trunk?
Thanks @gziolo for reviewing the code, I will make the neccessary changes in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that it fixes the issue.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @rithik56. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Congratulations on your first merged pull request, @rithik56! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
…e files (WordPress#58176) * added chunk filename in webpack config to avoid reading stale files from cache * fixed typo in webpack config * Update CHANGELOG.md --------- Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> Unlinked contributors: rithik56. Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: johnstonphilip <johnstonphilip@git.wordpress.org>
What?
Fixes #55397
Why?
Bug Fix
How?
By adding chunkFileName method in webpack.config.js and appending chunkhash in query params in order to avoid reading stale files from browser cache
Testing Instructions
N/A
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A