Interactivity API: Remove unused state and rename props to attributes in getElement()
#57974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Enhancement
cbravobernal
added
[Type] Enhancement
47 tasks
luisherranz
added
the
[Feature] Interactivity API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove state from
getElement()function.Rename
propstoattributesingetElement()function.I've put as a breaking change just in case, but state should have not been used by a third party developer yet.
Why?
attributes, as the props received will always be HTML attributes.As discussed on the update of the store(). See link.
Testing Instructions
Interactivity should not be broken. You can test navigation, search, query without forcing reload, etc.