Performance: only call useBlockEditingMode for selected blocks #57941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
changed the title
ellatrix
commented
Jan 17, 2024
| */ | ||
| export default function HeadingLevelDropdown( { | ||
| options = HEADING_LEVELS, | ||
| value, | ||
| onChange, | ||
| } ) { | ||
| const blockEditingMode = useBlockEditingMode(); |
There was a problem hiding this comment.
Alternatively we move the this to context and useBlockEditingMode just grabs the context instead of subscribing to the store.
There was a problem hiding this comment.
This might be a more future-proof solution. Do you see any downsides to it?
There was a problem hiding this comment.
Might be good to get @noisysocks' opinion.
I think there are quite a few places that use useBlockEditingMode in this way so if there's a way to reduce the performance impact in a more widespread way, it might indeed be a better option.
There was a problem hiding this comment.
Ok, I created #57950. That's a better solution.
|
Size Change: -23 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
commented
Jan 17, 2024
| @@ -32,14 +33,18 @@ const POPOVER_PROPS = { | |||
| * Dropdown for selecting a heading level (1 through 6) or paragraph (0). | |||
| * | |||
| * @param {WPHeadingLevelDropdownProps} props Component props. | |||
| * | |||
| * @return {ComponentType} The toolbar. | |||
There was a problem hiding this comment.
This is giving me an error, not sure why, I didn't change the return at all.
talldan
reviewed
Jan 18, 2024
| /> | ||
| </BlockControls> | ||
| ) } | ||
| <BlockControls group="block"> |
There was a problem hiding this comment.
Changing the logic to per-control does leave an empty toolbar group:
But maybe it's possible to fix that another way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #57906. This is adding a store subscription for each paragraph and heading block.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast