-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a control per block to reset pattern overrides #57907
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3486af9
Add a control per block to reset pattern overrides
kevin940726 2465917
Reword the control
kevin940726 878acd9
Update code to check for new block condensed bindings format
talldan 64fbe18
Fix the name field
kevin940726 d4deb25
Add e2e test
kevin940726 7421a50
Fix nested block
kevin940726 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
packages/patterns/src/components/reset-overrides-control.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { | ||
store as blockEditorStore, | ||
BlockControls, | ||
} from '@wordpress/block-editor'; | ||
import { ToolbarButton, ToolbarGroup } from '@wordpress/components'; | ||
import { useSelect, useRegistry } from '@wordpress/data'; | ||
import { store as coreStore } from '@wordpress/core-data'; | ||
import { parse } from '@wordpress/blocks'; | ||
import { __ } from '@wordpress/i18n'; | ||
|
||
function recursivelyFindBlockWithId( blocks, id ) { | ||
for ( const block of blocks ) { | ||
if ( block.attributes.metadata?.id === id ) { | ||
return block; | ||
} | ||
|
||
const found = recursivelyFindBlockWithId( block.innerBlocks, id ); | ||
if ( found ) { | ||
return found; | ||
} | ||
} | ||
} | ||
|
||
export default function ResetOverridesControl( props ) { | ||
const registry = useRegistry(); | ||
const id = props.attributes.metadata?.id; | ||
const patternWithOverrides = useSelect( | ||
( select ) => { | ||
if ( ! id ) { | ||
return undefined; | ||
} | ||
|
||
const { getBlockParentsByBlockName, getBlocksByClientId } = | ||
select( blockEditorStore ); | ||
const patternBlock = getBlocksByClientId( | ||
getBlockParentsByBlockName( props.clientId, 'core/block' ) | ||
)[ 0 ]; | ||
|
||
if ( ! patternBlock?.attributes.content?.[ id ] ) { | ||
return undefined; | ||
} | ||
|
||
return patternBlock; | ||
}, | ||
[ props.clientId, id ] | ||
); | ||
|
||
const resetOverrides = async () => { | ||
const editedRecord = await registry | ||
.resolveSelect( coreStore ) | ||
.getEditedEntityRecord( | ||
'postType', | ||
'wp_block', | ||
patternWithOverrides.attributes.ref | ||
); | ||
const blocks = editedRecord.blocks ?? parse( editedRecord.content ); | ||
const block = recursivelyFindBlockWithId( blocks, id ); | ||
|
||
props.setAttributes( block.attributes ); | ||
}; | ||
|
||
return ( | ||
<BlockControls group="other"> | ||
<ToolbarGroup> | ||
<ToolbarButton | ||
onClick={ resetOverrides } | ||
disabled={ ! patternWithOverrides } | ||
__experimentalIsFocusable | ||
> | ||
{ __( 'Reset' ) } | ||
</ToolbarButton> | ||
</ToolbarGroup> | ||
</BlockControls> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of a gotcha here that if the attributes are different
RichTextData
instances then===
won't be true even though we expect them to be most of the time. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really think of another way, so this looks ok to me.