Interactivity API: Prevent the use of components in wp-text
#57879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Enhancement
cbravobernal
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad,
ajitbohra,
luisherranz and
DAreRodz
as code owners
47 tasks
|
Size Change: +79 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
luisherranz
reviewed
Jan 16, 2024
luisherranz
reviewed
Jan 16, 2024
luisherranz
changed the title
wp-textwp-text
luisherranz
reviewed
Jan 16, 2024
luisherranz
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow only returning types that have a
toString()when using the wp-directive-text.Why?
To prevent screens showing undefineds and [Object Object] if the developer makes a type mistake.
How?
Returning null if type is different from a string.
Testing Instructions
Automatic tests are included.
PD: Question from @DAreRodz: should we allow numbers?
CC: @luisherranz