Template/Page Editing UX: Try highlighting what's editable #57786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…light what's editable using CSS
|
Size Change: +427 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
This is really rough, but I want to see if @youknowriad thinks it's a dumb idea to add a new block ( |
noisysocks
added
[Type] Technical Prototype
|
I think the main problem with "adding virtual blocks" is that you'll end up with markup that doesn't match the frontend breaking the visual representation in subtle ways (things like layout, first/last CSS selectors... and others might break as a result). |
|
Jfyi (or for inspiration), It's not optimized for locked blocks, but if they have a css class I could imagine just not showing the border then. Screen.Recording.2024-01-14.at.11.52.06.mp4 |
|
Trying a different approach 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
First attempt at implementing Part 1 of #55025.
Why?
See #55025.
How?
When editing a page in the site editor in
post-onlymode, we wrap everything with a new Template block. This is an internal (supports.inserter: false) block that is similar to Template Part and renders the specified template. By wrapping everything in a block, we can achieve the desired effect shown in Part 1 of #55025 where clicking on a block that is part of the template results in a block toolbar appearing with an Edit button.Testing Instructions
Screenshots or screencast
Kapture.2024-01-12.at.15.23.57.mp4