Use is-layout pattern on layout generated classname
#57564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Enhancement
tellthemachines
requested review from
spacedmonkey and
ellatrix
as code owners
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/layout.php |
|
Size Change: +2 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Nice change, that makes the class check feel more stable 👍
✅ Classnames are output correctly in the editors and site frontend
✅ Blocks themes work as before when applying layout rules at the individual block level
✅ Classic themes using appearance-tools can still set block spacing correctly for the Group block
Example editor markup
Example site frontend markup
LGTM! ✨
andrewserong
added
the
[Feature] Layout
tellthemachines
removed
the
[Type] Bug
|
✅ I updated the PHP Sync Tracking Issue to note this PR does not require a backport. Noting also that I've updated the script that generates the PHP Sync Issue so that it ignores PRs which are backported from Core to Gutenberg so PRs like this one won't be flagged in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Syncs update to generated layout classname from WordPress/wordpress-develop#5812. The idea is that all layout classnames can now share the
is-layout-string, so that they can more easily be identified. The change is applied when searching for the layout classes in the legacy group inner container support function.Testing Instructions
add_theme_support( 'appearance-tools');in the theme's setup function.phpunit/block-supports/layout-test.phpshould still pass.Testing Instructions for Keyboard
Screenshots or screencast