Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Editable Permalinks #5756

Merged
merged 63 commits into from
Apr 15, 2018
Merged

Add Editable Permalinks #5756

merged 63 commits into from
Apr 15, 2018
+525 −69

Commits on Apr 13, 2018

  1. Remove the copy button, add the Change Permalinks button

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    b9c5934 View commit details
    Browse the repository at this point in the history

  2. Display the sample permalink

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    4f1c501 View commit details
    Browse the repository at this point in the history

  3. Remove the last bits of the Copy button

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    8a451e2 View commit details
    Browse the repository at this point in the history

  4. Add the permalink editing form

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    8353e7b View commit details
    Browse the repository at this point in the history

  5. Fix a strange PHP notice, because WordPress is strange.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    6253a45 View commit details
    Browse the repository at this point in the history

  6. Turn the Dashicon into a ClipboardButton

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    6d99339 View commit details
    Browse the repository at this point in the history

  7. Grey the icon after it's been clicked.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    e1e0830 View commit details
    Browse the repository at this point in the history

  8. Use Tooltip for the permalink copy button tip

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    8307f97 View commit details
    Browse the repository at this point in the history

  9. Rename the copied CSS class to is-copied

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    e7a3547 View commit details
    Browse the repository at this point in the history

  10. Tweak the form a bit

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    034a077 View commit details
    Browse the repository at this point in the history

  11. Move the permalink edit form to its own component.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    19aa275 View commit details
    Browse the repository at this point in the history

  12. Allow for when the permalink hasn't been changed.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    a7da16a View commit details
    Browse the repository at this point in the history

  13. Switch to using withDispatch() instead of using editPost() directly.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    a44c379 View commit details
    Browse the repository at this point in the history

  14. 💪🏻📦

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    7a23f77 View commit details
    Browse the repository at this point in the history

  15. Check that we have a sample permalink before we try to use it.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    ab21ea5 View commit details
    Browse the repository at this point in the history

  16. The sample_permalink is also the actual permalink for published posts.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    a0b9205 View commit details
    Browse the repository at this point in the history

  17. Don't add a sample permlink for post types that aren't public.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    8523412 View commit details
    Browse the repository at this point in the history

  18. Move the PostPermalink component after the title editor.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    4b0bce4 View commit details
    Browse the repository at this point in the history

  19. Make the permalink editor input autofocus when the form is opened.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    edbbe9e View commit details
    Browse the repository at this point in the history

  20. Move the permalink copy button later in the DOM, for better keyboard … 

    …tabbing.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    d9a8440 View commit details
    Browse the repository at this point in the history

  21. Allow autofox to be used on the permalink editor form.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    6761c51 View commit details
    Browse the repository at this point in the history

  22. Remove the full stop from the tooltip text.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    680b4b6 View commit details
    Browse the repository at this point in the history

  23. Revert "Move the permalink copy button later in the DOM, for better k… 

    …eyboard tabbing."

This reverts commit 996fd9a.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    85c4bda View commit details
    Browse the repository at this point in the history

  24. After the permalink is saved, focus on the new permalink.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    6660458 View commit details
    Browse the repository at this point in the history

  25. Use ellipsis for overflow of the URL prefix.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    3778a32 View commit details
    Browse the repository at this point in the history

  26. Add a comment to explain autofocus being allowed

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    4e83662 View commit details
    Browse the repository at this point in the history

  27. Prevent the form from doing the default submit action.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    95b5ceb View commit details
    Browse the repository at this point in the history

  28. Add a focus() method to Button, so the element can be focussed.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    d8f1ef2 View commit details
    Browse the repository at this point in the history

  29. Use Button's new focus() method to focus it.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    7a2a12c View commit details
    Browse the repository at this point in the history

  30. Use the edited post name as the form text input value.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    3ea1481 View commit details
    Browse the repository at this point in the history

  31. Replace connect() with withSelect()

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    71a29c7 View commit details
    Browse the repository at this point in the history

  32. Use the Button isLarge property, instead of the button class.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    c135851 View commit details
    Browse the repository at this point in the history

  33. Add an edge to the permalink button fade.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    8bbcf6e View commit details
    Browse the repository at this point in the history

  34. Add an is_viewable flag to post_type API responses.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    b697cae View commit details
    Browse the repository at this point in the history

  35. Always add the sample permalink to post responses.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    2b0156c View commit details
    Browse the repository at this point in the history

  36. Don't show the PostPermalink on post types that aren't viewable.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    b281331 View commit details
    Browse the repository at this point in the history

  37. Remove some old permalink data validity checks

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    6f796fb View commit details
    Browse the repository at this point in the history

  38. Remove a redundant CSS block.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    02dea6c View commit details
    Browse the repository at this point in the history

  39. Remove some more redundant CSS.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    a02c4a0 View commit details
    Browse the repository at this point in the history

  40. Fix some failing unit tests.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    5e6baab View commit details
    Browse the repository at this point in the history

  41. lov2work w/ old phpunit

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    c401948 View commit details
    Browse the repository at this point in the history

  42. Make the permalink display in the correct order in LTR languages. 

    Duplicates a similar fix in the classic editor.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    65cf88e View commit details
    Browse the repository at this point in the history

  43. Rename sample_permalink to permalink_template, remove the duplica… 

    …tion of the postname, and reshuffle the relevant code.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    b0be34a View commit details
    Browse the repository at this point in the history

  44. Fix Travis

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    19f4f3a View commit details
    Browse the repository at this point in the history

  45. Reset the local copy of the postname, if the server has returned a sa… 

    …ntised version.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    aeb3a84 View commit details
    Browse the repository at this point in the history

  46. Actually fix Travis.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    14d23ee View commit details
    Browse the repository at this point in the history

  47. 💀

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    38e5444 View commit details
    Browse the repository at this point in the history

  48. Allow the postname field to be cleared.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    380f40e View commit details
    Browse the repository at this point in the history

  49. Button: remove an unnecessary bind().

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    98c36f7 View commit details
    Browse the repository at this point in the history

  50. Rename editingPermalink to isEditingPermalink.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    f63debc View commit details
    Browse the repository at this point in the history

  51. Nudge the copy button a little.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    daa4b8f View commit details
    Browse the repository at this point in the history

  52. Refresh the post when the user returns to the page after having click… 

    …ed the Change Permalinks button.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    1f703b0 View commit details
    Browse the repository at this point in the history

  53. Add tests for the permalink selectors.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    40eff87 View commit details
    Browse the repository at this point in the history

  54. Use getPostType() for getting the post type.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    0bf43de View commit details
    Browse the repository at this point in the history

  55. Fix some linting errors.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    5db2b58 View commit details
    Browse the repository at this point in the history

  56. Move the addEventListener to a callback, and remove it when the compo… 

    …nent is unmounting.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    6ded524 View commit details
    Browse the repository at this point in the history

  57. Rename UPDATE_POST_FROM_SERVER to REFRESH_POST

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    fb49a35 View commit details
    Browse the repository at this point in the history

  58. Performance improvement of a get() call.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    91e26fb View commit details
    Browse the repository at this point in the history

  59. Remove POSTNAME_SANITIZED, handle it in UPDATE_POST

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    17392bd View commit details
    Browse the repository at this point in the history

  60. Remove the GET method from the post refresh request, as that's the de… 

    …fault.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    48fbdec View commit details
    Browse the repository at this point in the history

  61. Rename the posttype is_viewable flag to viewable.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    8766dab View commit details
    Browse the repository at this point in the history

  62. Add a draft_slug to the REST API response for posts that are drafts, … 

    …and don't have a slug defined.
    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    7e56148 View commit details
    Browse the repository at this point in the history

  63. Linting.

    @pento
    pento committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    6d3960f View commit details
    Browse the repository at this point in the history