-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Unify spotlight mode preference #57533
Conversation
Size Change: -47 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @youknowriad!
Besides one note for the Site Editor, the changes test well for me.
✅ The preference is correctly migrated.
✅ The preference is shared between editors.
❌ The site editor is displaying in spotlight mode when canvas mode is view
.
@@ -144,7 +139,6 @@ export function useSpecificEditorSettings() { | |||
|
|||
richEditingEnabled: true, | |||
supportsTemplateMode: true, | |||
focusMode: canvasMode === 'view' && focusMode ? false : focusMode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change; the spotlight mode will now apply in view mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can restore it but I don't like that part :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current behavior creates bad UX when exploring theme styles.
Update: Actually, the behavior is the same on the trunk when browsing styles from the sidebar; this might be something we'll need to fix separately.
The 2da2fd6 fixed regression for view mode.
Related #52632
Similar to #57468
What?
This PR continues the work on the great unification between post and site editors. In this PR we're unifying the "Spotlight mode" preference. If the user enables it in the post editor, the setting should be used in the site editor as well.
Testing instructions