Gallery: Combine useSelect calls #57240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Performance
|
There are a number of other optimisations/tidy ups that could be done in this method, but will do them in little parts to keep it simple, so this one confined to just the useSelect. |
glendaviesnz
removed
the
[Type] Code Quality
|
Size Change: +4 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
LGTM 👍
✅ Adding gallery images via drag-n-drop, upload button, and media library works
✅ Removing images from the gallery worked as expected
✅ Reordering images continues to work
✅ Gallery image settings were applied to inner images correctly
✅ Didn't spot any differences with trunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Combines the 3 separate
useSelectcalls in the Gallery edit component into one.Why?
Haveing multiple
useSelectcalls in a component is not optimal for performance reasons.How?
Pulled the second two calls into the first one.
Testing Instructions