Allow default duotone styles in classic themes.

[tellthemachines]

What?

Fixes one of the issues detected in #56131, although it's not specific to classic themes with support for appearance tools, but all classic themes and block themes without theme duotone presets.

This allows the default duotone presets to display if they're not explicitly disabled in theme.json.

I don't know all the history behind the decision to not have defaults enabled for themes without their own, but it seems that at least since #49103 filters are no longer output on every page, so if that was the concern it should be OK to enable now.

Testing Instructions

1. With a classic theme, add an Image block and open the duotone dropdown from the block toolbar;
2. Verify that default duotone options appear in the dropdown;
3. Select one, save and check that editor matches front end.

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/class-wp-theme-json-resolver-gutenberg.php

[ajlende]

I don't know all the history behind the decision to not have defaults enabled for themes without their own, but it seems that at least since #49103 filters are no longer output on every page, so if that was the concern it should be OK to enable now.

I honestly don't fully remember either, but enabling them now sounds good to me. 👍

[andrewserong]

so if that was the concern it should be OK to enable now.

I imagine that was the main concern, so that classic themes that aren't using Duotone don't output unneeded markup or styles. So sounds like it's unblocked!

[andrewserong]

Looking good!

✨

[tellthemachines]

Thanks for the reviews folks!

[getdave]

@tellthemachines You've removed the Needs PHP Backport label on this Issue. For tracking purposes, could you advise why these changes don't need backporting?

Apologies if you've already done this and I missed it 🙇

[tellthemachines]

@getdave could you please read through the history previous to the label removal, you'll see there's a link to a core backport PR that has been committed. For tracking purposes, the backport label is removed as soon as the backport is concluded.

[getdave]

Thanks.

[getdave]

✅ I updated this PR with the Backported to Core label to indicate that the backport was successfully merged into WP Core. I also updated the PHP Sync Tracking Issue for WP 6.5 with the missing Trac and Core Backport PR links.