Global styles revisions e2e: tidy up selectors to open revisions panel #57146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns list so we don't need to click it.
kevin940726
approved these changes
Dec 18, 2023
test/e2e/specs/site-editor/user-global-styles-revisions.spec.js
Outdated
Show resolved
Hide resolved
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Thanks for the super quick review @kevin940726 |
|
Flaky tests detected in 4d926e7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7243224051
|
bph
added
the
[Type] Automated Testing
Mamaduka
removed
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removing playwright locator and action on the global styles ellipsis menu in
openRevisions, which is meant to open the revisions panel.Why?
Since #56454 the revisions button is no longer in the drop down actions list so we don't need to click it.
How?
DELETE!
Testing Instructions
The tests in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js should pass.