List: avoid useSelect in block render #57077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 27ae6ba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7213417478
|
youknowriad
reviewed
Dec 14, 2023
youknowriad
reviewed
Dec 14, 2023
| @@ -19,71 +19,72 @@ import useOutdentListItem from './use-outdent-list-item'; | |||
|
|
|||
There was a problem hiding this comment.
not sure what you did here but I think I copied this one to button block, so you think it can be improved there too?
There was a problem hiding this comment.
That doesn't have a mapping useSelect because there's no outdent/indent
youknowriad
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently we're adding 3 useSelect store subscriptions for every list item through the indent/outdent hooks. This information is not even needed at render time, except for the controls (which are not rendered unless the block is selected). The other uses are in callbacks. Let's check the store in the callbacks and move subscriptions to the controls.
Why?
First run 16.7%
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast