(edit-site)(use-init-edited-entity-from-url) Safely access toString() on siteData's page_on_front
#57035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -727 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 10b4e27. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7211776067
|
youknowriad
reviewed
Dec 14, 2023
packages/edit-site/src/components/sync-state-with-url/use-init-edited-entity-from-url.js
Outdated
Show resolved
Hide resolved
youknowriad
approved these changes
Dec 14, 2023
fullofcaffeine
added
the
[Type] Bug
fullofcaffeine
deleted the
add/guard-to-possibly-null-page-on-front-property-of-site-data
branch
noahtallen
pushed a commit
that referenced
this pull request
Dec 15, 2023
…)` on `siteData`'s `page_on_front` (#57035)
noahtallen
pushed a commit
that referenced
this pull request
Dec 15, 2023
…)` on `siteData`'s `page_on_front` (#57035)
fullofcaffeine
changed the title
toString() on siteData's page_on_front as it migh…toString() on siteData's page_on_front
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
…)` on `siteData`'s `page_on_front` (#57035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Safely access
toString()on possiblynullproperty.Why?
In some circunstances/edge cases,
siteData.page_on_frontmight benull, causing aTypeErrorand completely BSODing the Site Editor.@youknowriad clarified that it might be a
stringornumber.How?
See
What.