Editor: Move the panel visibility state from the edit-post to the editor package #57012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
requested review from
ntwb,
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +207 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 79e78da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7202074901
|
youknowriad
force-pushed
the
update/panel-visibility-state
branch
from
5053455 to
79e78da
Compare
ellatrix
reviewed
Dec 14, 2023
| @@ -879,6 +879,45 @@ _Returns_ | |||
|
|
|||
| - `boolean`: Whether the post can be saved. | |||
|
|
|||
| ### isEditorPanelEnabled | |||
There was a problem hiding this comment.
Would be great if it explained a bit more what this editor panel is.
There was a problem hiding this comment.
it's just the panels that shows up in the sidebar of the editor: things like "post categories", "post featured image"...
ellatrix
approved these changes
Dec 14, 2023
bph
added
the
[Feature] Site Editor
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR continues the work on the great unification between post and site editors. The edit-post package holds some state (actions and selectors) that are used to persist the state of the panels (opened, closed, enabled...). In order to use these panels in the site editor as well, we need to unify that state as well by moving it to the editor package. This PR does that.
Testing instructions