[Data Views] Adding aria-sort to table view headers
#56860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures sorting semantics are not just communicated visually
andrewhayward
added
[Type] Enhancement
andrewhayward
requested review from
youknowriad,
oandregal,
ntsekouras and
a team
andrewhayward
commented
Dec 7, 2023
| @@ -545,6 +545,9 @@ function ViewTable( { | |||
| // TODO:Add spinner or progress bar.. | |||
| return <h3>{ __( 'Loading' ) }</h3>; | |||
| } | |||
|
|
|||
| const sortValues = { asc: 'ascending', desc: 'descending' }; | |||
There was a problem hiding this comment.
Don't know if there's a general preference for raw objects or Maps, but happy to change this as necessary...
Suggested change
| const sortValues = { asc: 'ascending', desc: 'descending' }; | |
| const sortValues = new Map([ ['asc', 'ascending'] , ['desc', 'descending'] ]); |
ntsekouras
approved these changes
Dec 7, 2023
|
Size Change: +30 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1705e2c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7127856999
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds
aria-sortto column headers in table view. Resolves #56853.Why?
Ensures sorting semantics are not just communicated visually
How?
Every column header gets an
aria-sortprop with a value appropriate for the sort status of the column ("ascending"/"descending"/undefined).Testing Instructions
aria-sorton the correct<th>, eitherascendingordescendingas appropriate, and thataria-sortdoes not appear on any other<th>.