SlotFill: Allow contextual SlotFillProviders #56779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +23 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 629e5ff. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7193766454
|
youknowriad
force-pushed
the
fix/slot-fill-breaking-change
branch
from
f8ea0bc to
a9d4b3c
Compare
jsnajdr
approved these changes
Dec 13, 2023
youknowriad
force-pushed
the
fix/slot-fill-breaking-change
branch
from
a9d4b3c to
629e5ff
Compare
bph
added
the
[Feature] Extensibility
mikachan
pushed a commit
that referenced
this pull request
Jan 3, 2024
# Conflicts: # packages/components/CHANGELOG.md
|
👋 @youknowriad, I've just cherry-picked this so it's included in the next 6.4 point release, but I had to include several other PRs to make sure the build ran correctly:
As there are so many, I just wanted to double-check if this sounds right before I went any further. Here's the branch I'm working with for the next release: #57360 Thanks! |
mikachan
removed
the
Backport to WP Minor Release
|
@mikachan That sounds like a lot of PRs and changes just for this to be cherry-picked, personally I'd have just applied the same fix on the non-typescript version. (Basically adding the passthrough prop and passing it) |
mikachan
added a commit
that referenced
this pull request
Jan 3, 2024
|
That makes more sense! I wasn't sure how important it was to keep the changes in line with the current version of GB, but applying the changes to the non-typescript version is much easier 😅 I've done that now here: 733b844 |
|
LGTM 👍 Thanks |
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
mikachan
pushed a commit
that referenced
this pull request
Jan 5, 2024
# Conflicts: # packages/components/CHANGELOG.md
mikachan
added a commit
that referenced
this pull request
Jan 5, 2024
This was referenced Jan 5, 2024
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jan 9, 2024
Package Update includes fixes for: - Image Block: Enable image block to be selected correctly when clicked. - Reduce specificity of default Cover text color styles. - Image Block: Fix deprecation when width/height attribute is number. - Text selection: show CSS hack to Safari only. - SlotFill: Allow contextual SlotFillProviders. See: #5696 See: WordPress/gutenberg@bd6767b See: WordPress/gutenberg#56043 See: WordPress/gutenberg#56411 See: WordPress/gutenberg#57063 See: WordPress/gutenberg#57300 See: WordPress/gutenberg#56779 Props mikachan, wildworks, alexstine, poena, isabel_brison, andrewserong, czapla, andraganescu, joen, ellatrix, youknowriad, ntsekouras. Fixes #59943, #59943. git-svn-id: https://develop.svn.wordpress.org/trunk@57258 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jan 9, 2024
Package Update includes fixes for: - Image Block: Enable image block to be selected correctly when clicked. - Reduce specificity of default Cover text color styles. - Image Block: Fix deprecation when width/height attribute is number. - Text selection: show CSS hack to Safari only. - SlotFill: Allow contextual SlotFillProviders. See: WordPress/wordpress-develop#5696 See: WordPress/gutenberg@bd6767b See: WordPress/gutenberg#56043 See: WordPress/gutenberg#56411 See: WordPress/gutenberg#57063 See: WordPress/gutenberg#57300 See: WordPress/gutenberg#56779 Props mikachan, wildworks, alexstine, poena, isabel_brison, andrewserong, czapla, andraganescu, joen, ellatrix, youknowriad, ntsekouras. Fixes #59943, #59943. Built from https://develop.svn.wordpress.org/trunk@57258 git-svn-id: http://core.svn.wordpress.org/trunk@56764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jan 9, 2024
Package Update includes fixes for: - Image Block: Enable image block to be selected correctly when clicked. - Reduce specificity of default Cover text color styles. - Image Block: Fix deprecation when width/height attribute is number. - Text selection: show CSS hack to Safari only. - SlotFill: Allow contextual SlotFillProviders. See: WordPress/wordpress-develop#5696 See: WordPress/gutenberg@bd6767b See: WordPress/gutenberg#56043 See: WordPress/gutenberg#56411 See: WordPress/gutenberg#57063 See: WordPress/gutenberg#57300 See: WordPress/gutenberg#56779 Props mikachan, wildworks, alexstine, poena, isabel_brison, andrewserong, czapla, andraganescu, joen, ellatrix, youknowriad, ntsekouras. Fixes #59943, #59943. Built from https://develop.svn.wordpress.org/trunk@57258 git-svn-id: https://core.svn.wordpress.org/trunk@56764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #56519
What?
In #53940 we refactored SlotFillProvider to allow the BlockEditorProvider to bundle a provider and if a parent provider was already on the tree, the bundled provider would just pass the slots to the parent provider which means slots and fills will continue to render at the same position.
That behavior caused a regression because it seems some people were relying explicitly on the "contextual" aspect of SlotFillProvider in the editor UI
This PR introduces a prop to make SlotFillProvider contextual by default but allow BlockEditorProvider to pass through Slots to the parent provider.
Testing Instructions