-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid to show unnecessary Tooltip for the Post Schedule button. #56759
Merged
afercia
merged 1 commit into
trunk
from
fix/post-schedule-button-avoid-unnecessary-tooltip
Dec 6, 2023
Merged
Avoid to show unnecessary Tooltip for the Post Schedule button. #56759
afercia
merged 1 commit into
trunk
from
fix/post-schedule-button-avoid-unnecessary-tooltip
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
An existing feature does not function as intended
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Package] Editor
/packages/editor
labels
Dec 4, 2023
Size Change: +2 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/post-schedule-button-avoid-unnecessary-tooltip
branch
from
December 4, 2023 14:53
9e0d1b1
to
7dbce45
Compare
youknowriad
approved these changes
Dec 5, 2023
afercia
deleted the
fix/post-schedule-button-avoid-unnecessary-tooltip
branch
December 6, 2023 07:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Package] Editor
/packages/editor
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56755
What?
The Post Schedule button may show a tooltip that just repeats the visible text.
Why?
Unnecessary tooltips should be avoided as they just clutter the UI.
How?
Only shows the Tooltip when it actually contains expanded information compared to the visible text by checking whether
label
andfullLabel
are not the same.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast