Clean up header toolbar metrics and responsive break points #56729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -70 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
richtabor
added
[Type] Enhancement
|
Thank you for the followup! This is much better, but it might actually need a little more tweaks which I'm happy to push on Monday. Shown here, the 4px gap of tools on the left:
You can also see there's some right-margin next to the blue add button, that's messing the spacing up. It should actually be 8px like it is on the right:
There's even something weird, perhaps it's just that screenshot, about the inspector button. This was meant to match the block toolbar:
But upon investigation, even there I have a followup to do: That gap is also 4px. |
Sure thing, I can resolve that. I assumed it had more breathing space, to emulate the space to its left. |
Sure thing, feel free to. 🙂 |
|
Alright, pushed a fix, and I think things are good now:
|
jasmussen
approved these changes
Dec 4, 2023
|
Added a few more adjustments. Mind doing one more look over @jasmussen?
|
|
In principle, good, however despite my past feedback, the -4px negative margin on the ellipsis was actually intentional. I had forgotten it in my first round of feedback, but essentially because the ellipsis is such a "thin" icon, we added that negative space to make it more optically balanced. I wonder in fact if it should be -8px now? Not sure it's the best solution, and not a blocker, let me know your thoughts. |
Yes, that's fine. I think -4 works best as a happy medium, so it does not look too off when the closest item is selected. |
richtabor
force-pushed
the
tweak/edit-site-doc-tools
branch
from
812972e to
250621d
Compare
|
Flaky tests detected in 250621d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7091104554
|
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up to #56635, adding the missing gap between the document tool icons and tightening up the mobile views by consolidating breakpoint changes and applying more consistent metrics on mobile.
How?
Testing Instructions
Screenshots or screencast
Area.mp4