Fixture Tests: Correctly generate fixture files for form-related blocks #56719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: -16 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/class-block-fixture-test.php |
t-hamano
commented
Dec 1, 2023
Comment on lines
+10
to
+14
| public function filter_allowed_html( $tags ) { | ||
| $tags['form']['class'] = true; | ||
| $tags['form']['enctype'] = true; | ||
| return $tags; | ||
| } |
There was a problem hiding this comment.
The wp_kses_post() function does not allow form tag by default. So we need to allow attributes to be included in the serialized form block.
t-hamano
commented
Dec 1, 2023
Comment on lines
38
to
43
| /* eslint-disable no-restricted-syntax */ | ||
| import * as form from '@wordpress/block-library/build-module/form'; | ||
| import * as formInput from '@wordpress/block-library/build-module/form-input'; | ||
| import * as formSubmitButton from '@wordpress/block-library/build-module/form-submit-button'; | ||
| import * as formSubmissionNotification from '@wordpress/block-library/build-module/form-submission-notification'; | ||
| /* eslint-enable no-restricted-syntax */ |
There was a problem hiding this comment.
If you have a better approach than this, please let me know.
t-hamano
requested review from
aristath,
gziolo,
ellatrix,
jorgefilipecosta and
aaronrobertshaw
aristath
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56590
This issue was discovered in this comment: #56507 (comment)
What?
This PR will ensure that the fixture files for the following two blocks are generated correctly.
test/integration/fixtures/blocks/core__form-input.htmltest/integration/fixtures/blocks/core__form.htmlAdditionally, this PR creates fixture files for form-related blocks that do not yet exist.
test/integration/fixtures/blocks/core__form-submission-notification.htmltest/integration/fixtures/blocks/core__form-submit-button.htmlWhy?
These blocks are not available unless you explicitly opt-in on the Experimental Settings page. In other words, in fixture tests, it is excluded from the blocks registered with the
registerBlocks()function.As a result, even if you create a fixture file, that block will be considered a
core/missingblock and will not generate a correct serialized file that has passed deprecation.How?
getNameFromLabel()function no longer depends on thedocumentobject to avoid fixture test failures. (See the "The behavior of the save function of the Input Field block is different in the fixture test" section in #56590 for details.)Testing Instructions
Confirm that the form-input block's save function outputs exactly the same markup as before.