Modules: Fix import map polyfill not being copied on the generated plugin ZIP #56655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Type] Bug
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/interactivity-api/modules.php |
|
Size Change: -12.2 kB (-1%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
@luisherranz @c4rl0sbr4v0 checking; should this be backported to the current 17.2 RC? Seems like its milestone was set for 17.3, but I'm guessing that's not correct. |
vcanales
pushed a commit
that referenced
this pull request
Dec 5, 2023
|
Backported to 17.2 RC |
vcanales
removed
the
Backport to Gutenberg RC
|
Thanks @vcanales , it is better to have it on 17.2 than waiting for the next release 😅 |
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
cbravobernal
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move the
importmap-polyfill.jsfile to themodulesfolder.Why?
Because the build script doesn't copy anything outside folders (notice the single
*):ls build/*/*.{js,js.map,css,asset.php}https://github.com/WordPress/gutenberg/blob/trunk/bin/build-plugin-zip.sh#L82
How?
I tried with
ls build/**/*.{js,js.map,css,asset.php}, but that generated a lot of extra files. So I just moved theimportmap-polyfill.jsfile to themodulesfolder to make it work with the current logic.Testing Instructions
importmap-polyfill.jsfile is downloaded correctly.