-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Add the transforms page to the create block tutorial of the platform docs #56559
Conversation
…f the platform docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments but it looks good to me.
One thing I noticed is that the custom block names in the "Create a block type" section are a mix of create-block/gutenpride
and gutenpride/gutenpride-block
. Perhaps we should unify to gutenpride/gutenpride-block
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, so giving it a ✅
Co-authored-by: Héctor <27339341+priethor@users.noreply.github.com>
Good remark, I fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Flaky tests detected in 4471c35. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7018655521
|
…f the platform docs (#56559) Co-authored-by: Héctor <27339341+priethor@users.noreply.github.com>
Related #53874
What?
This is the forth page of the "create block type" tutorial on the "Gutenberg as framework" documentation website. It adds block transformations. I think we need to move the "reference" pages to the platform docs instead of the current handbook to be able to link to the "references" from both places, but that's for later.
For instance, I think we need a reference page for the transforms, the block supports...
You can check the current state of the website locally by doing: