Remove compatibility layer for WP 6.2

[tellthemachines]

What?

Gutenberg only supports the current and previous WP version, so now that 6.4 is out, the compatibility files supporting 6.2 can be removed. This PR removes those files and fixes any obvious resulting fatals, but I'd thank everyone, especially those who have made PHP changes recently, to test that stuff is still working!

For reference, the corresponding PR after 6.3: #53451

Testing Instructions

Open all the pages, click around, check nothing's broken. In particular, there's a lot of changes in here related to templates, patterns, navigation and revisions so those areas are good to pay special attention to.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.4/class-gutenberg-rest-block-patterns-controller.php
❔ lib/compat/wordpress-6.4/class-gutenberg-rest-global-styles-revisions-controller-6-4.php
❔ lib/experimental/class-gutenberg-rest-template-revision-count.php
❔ lib/load.php

[Mamaduka]

This will also require changing the commit SHA for the performance test. See #54107 (comment).

[tellthemachines]

The perf tests are already failing on trunk since #56427

The commit hash was updated here but tests are still failing; we probably need to pick another commit 😅

[tellthemachines]

I just tried another commit based on the logic you used in #54111; let's see if it works 🤞

[gziolo]

PHPUnit test failures were reported on CI, which is reasonably expected when removing unused classes and functions:

In the past, we either tweaked the tests if they still made sense in Gutenberg or we removed them in favor of test coverage in WordPress core.

[ramonjd]

Checked behaviour of Global styles revisions (Gutenberg_REST_Global_Styles_Revisions_Controller_6_3 removed) ✅

Also did a general smoke test of:

• site editor (editing and saving navigation, patterns, templates)
• foot notes (in post editor and in the site editor pages editor)

we removed them in favor of test coverage in WordPress core.

I've been meaning to prune Gutenberg_REST_Global_Styles_Revisions_Controller_Test, I'll get a PR to do this in light of this PR

[tellthemachines]

Thanks for the reviews and testing, folks!

PHPUnit test failures were reported on CI

I removed the two failing tests suites as they are already in core here and hereand it doesn't make sense to keep them in Gutenberg after removing the classes.

[mikachan]

Thank you for working on this!

I've done some general testing on viewing, editing, and saving:

• Navigation
• Patterns
• Templates
• Footnotes
• Revisions

Everything is looking good to me 👍 I didn't see any errors and all worked as expected.

[tellthemachines]

Thanks for testing everyone! I did a further round of testing too and everything seems to be working correctly. I think this is ready for a final review!

[andrewserong]

• Navigation
• Patterns
• Templates
• Footnotes
• Revisions

I've just given this PR a smoke test with all these, too, while running 6.3 with this PR applied. All looking good to me as well.

Since none of us have run into any issues in testing and a few of us have tested it out now, I reckon this is good to try! ✨

[getdave]

✅ I updated the PHP Sync Tracking Issue for WP 6.5 to note this PR does not require a backport for WP 6.5.