-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BoxControl
: Update story and refactor to Typescript
#56462
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fbcc931
BoxControl: Update story and refactor to Typescript
brookewp 881e973
Cleanup and refine story based on feedback
brookewp 219c1f5
Add Uncontrolled and Controlled templates and Controlled example
brookewp 8b6ba7a
Remove default values and fix values control
brookewp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
75 changes: 0 additions & 75 deletions
75
packages/components/src/box-control/stories/index.story.js
This file was deleted.
Oops, something went wrong.
82 changes: 82 additions & 0 deletions
82
packages/components/src/box-control/stories/index.story.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import type { Meta, StoryFn } from '@storybook/react'; | ||
|
||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { useState } from '@wordpress/element'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import BoxControl from '../'; | ||
|
||
const meta: Meta< typeof BoxControl > = { | ||
title: 'Components (Experimental)/BoxControl', | ||
component: BoxControl, | ||
argTypes: { | ||
values: { control: { type: null } }, | ||
}, | ||
parameters: { | ||
actions: { argTypesRegex: '^on.*' }, | ||
controls: { expanded: true }, | ||
docs: { canvas: { sourceState: 'shown' } }, | ||
}, | ||
}; | ||
export default meta; | ||
|
||
const TemplateUncontrolled: StoryFn< typeof BoxControl > = ( props ) => { | ||
return <BoxControl { ...props } />; | ||
}; | ||
|
||
const TemplateControlled: StoryFn< typeof BoxControl > = ( props ) => { | ||
const [ values, setValues ] = useState< ( typeof props )[ 'values' ] >(); | ||
|
||
return ( | ||
<BoxControl | ||
values={ values } | ||
{ ...props } | ||
onChange={ ( nextValue ) => { | ||
setValues( nextValue ); | ||
props.onChange?.( nextValue ); | ||
} } | ||
/> | ||
); | ||
}; | ||
|
||
export const Default = TemplateUncontrolled.bind( {} ); | ||
Default.args = { | ||
label: 'Label', | ||
}; | ||
|
||
export const Controlled = TemplateControlled.bind( {} ); | ||
Controlled.args = { | ||
...Default.args, | ||
}; | ||
|
||
export const ArbitrarySides = TemplateControlled.bind( {} ); | ||
ArbitrarySides.args = { | ||
...Default.args, | ||
sides: [ 'top', 'bottom' ], | ||
}; | ||
|
||
export const SingleSide = TemplateControlled.bind( {} ); | ||
SingleSide.args = { | ||
...Default.args, | ||
sides: [ 'bottom' ], | ||
}; | ||
|
||
export const AxialControls = TemplateControlled.bind( {} ); | ||
AxialControls.args = { | ||
...Default.args, | ||
splitOnAxis: true, | ||
}; | ||
|
||
export const AxialControlsWithSingleSide = TemplateControlled.bind( {} ); | ||
AxialControlsWithSingleSide.args = { | ||
...Default.args, | ||
sides: [ 'horizontal' ], | ||
splitOnAxis: true, | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the example Template below controls the
BoxControl
by passing it thevalue
prop, we should disable controls for thevalue
propThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The controls for the
values
prop are still enabledI believe that the right setting is
values: { control: { type: null } }