Code

Refactor <BlockToolbar />#56335

Code

Merged

jeryj merged 51 commits intotrunkWordPress/gutenberg:trunkfrom refactor/block-toolbarWordPress/gutenberg:refactor/block-toolbarCopy head branch name to clipboardDec 7, 2023

+725-759

Commits

Commits on Dec 7, 2023

• Rename <SelectedBlockTools /> to <BlockToolbarPopover />

  Show description for 41a3971
  jeryj

  committed
  41a3971

  Copy full SHA for 41a3971

• Refactor commit: BlockContextualToolbar returns BlockToolbar directly

  jeryj

  committed
  7169a95

  Copy full SHA for 7169a95

• Replace private <BlockContextualToolbar /> usage with public <BlockToolbar />

  jeryj

  committed
  d54573c

  Copy full SHA for d54573c

• Add notes. Name BlockToolbar props directly.

  jeryj

  committed
  92b4682

  Copy full SHA for 92b4682

• Remove unnecessary blockClientId check

  Show description for 62c68e8
  jeryj

  committed
  62c68e8

  Copy full SHA for 62c68e8

• Pass variant into <BlockToolbar />

  Show description for f0321b2
  jeryj

  committed
  f0321b2

  Copy full SHA for f0321b2

• Hide drag handle for fixed toolbars

  jeryj

  committed
  3096fa0

  Copy full SHA for 3096fa0

• Large refactor of BlockToolbar rendering flow.

  Show description for 08d3433
  jeryj

  committed
  08d3433

  Copy full SHA for 08d3433

• Only render BlockToolsPopover if block has been modified

  Show description for 548cf4a
  jeryj

  committed
  548cf4a

  Copy full SHA for 548cf4a

• Only use block popover on large screens

  jeryj

  committed
  c493c4c

  Copy full SHA for c493c4c

• Remove unused showEmptyBlockSideInserter props

  jeryj

  committed
  69ab86e

  Copy full SHA for 69ab86e

• Fix focus toolbar shortcut when breadcrumb and toolbar are both in DOM

  jeryj

  committed
  af2d5ea

  Copy full SHA for af2d5ea

• Cleanup Block Popover comments

  jeryj

  committed
  65eacfb

  Copy full SHA for 65eacfb

• Deprecate focusOnMount

  jeryj

  committed
  1f2b8bc

  Copy full SHA for 1f2b8bc

• Remove shouldUseKeyboardFocusShortcut prop from use in BlockToolbar

  jeryj

  committed
  4198787

  Copy full SHA for 4198787

• Add __experimentalBlockToolbarDisplay prop to BlockTools and implement in post-edit

  jeryj

  committed
  109b1a0

  Copy full SHA for 109b1a0

• Temporarily add isFixed prop back to sticky toolbar

  jeryj

  committed
  f10abb8

  Copy full SHA for f10abb8

• Use __experimentalBlockToolbarDisplay in Edit Widgets BlockTools

  jeryj

  committed
  9399a32

  Copy full SHA for 9399a32

• Fix incorrect if statement for block tools and add comment

  jeryj

  committed
  f66d417

  Copy full SHA for f66d417

• Use __experimentalBlockToolbarDisplay for widgets customizer

  jeryj

  committed
  464b8ba

  Copy full SHA for 464b8ba

• Remove isFixed from BlockToolbar component

  Show description for 5181df3
  jeryj

  committed
  5181df3

  Copy full SHA for 5181df3

• Update is-typing e2e tests

  Show description for 9fb88a6
  jeryj

  committed
  9fb88a6

  Copy full SHA for 9fb88a6

• Update storybook examples to use __experimentalBlockToolbarDisplay

  jeryj

  committed
  ae4c062

  Copy full SHA for ae4c062

• Hide block toolbar popover when typing

  jeryj

  committed
  4ac80ee

  Copy full SHA for 4ac80ee

• Use sticky toolbar on customize widget until small screen breakpoint

  jeryj

  committed
  ef72458

  Copy full SHA for ef72458

• Edit Post: hasFixedToolbar = do not render the <BlockToolbar /> within <BlockTools />

  Show description for 3e16898
  jeryj

  committed
  3e16898

  Copy full SHA for 3e16898

• Implement hasFixedToolbar setting off isLargeViewport for Widgets Editor

  jeryj

  committed
  afca15c

  Copy full SHA for afca15c

• Modify block toolbar border css to have fewer overrides

  jeryj

  committed
  9472b35

  Copy full SHA for 9472b35

• Update Storybook examples

  jeryj

  committed
  b2ba337

  Copy full SHA for b2ba337

• Implemenet customize-widget toolbar modes

  jeryj

  committed
  91cf32f

  Copy full SHA for 91cf32f

• Implement edit site toolbar modes

  jeryj

  committed
  60fd0e8

  Copy full SHA for 60fd0e8

• Add docs to the BlockToolbar

  jeryj

  committed
  e7fd68b

  Copy full SHA for e7fd68b

• Add hideDragHandle and unstyled variant props to fixed toolbars

  jeryj

  committed
  972ce93

  Copy full SHA for 972ce93

• Clarify focusOnMount deprecation comments

  jeryj

  committed
  df1efbe

  Copy full SHA for df1efbe

• Remove small white underline from parent block button

  Show description for ed37de4
  jeryj

  committed
  ed37de4

  Copy full SHA for ed37de4

• Set variant=unstyled as default value for BlockToolbar

  jeryj

  committed
  cdeca82

  Copy full SHA for cdeca82

• Fix error in variant name

  jeryj

  committed
  04b42a1

  Copy full SHA for 04b42a1

• Remove deleted scss file from build

  jeryj

  committed
  e842262

  Copy full SHA for e842262

• Switch BlockToolbar to named function

  jeryj

  committed
  c74e1c5

  Copy full SHA for c74e1c5

• Deprecate focusOnMount in NavigableToolbar README

  jeryj

  committed
  d84f0fe

  Copy full SHA for d84f0fe

• Show icon label toolbar fixes

  jeryj

  committed
  4d954bd

  Copy full SHA for 4d954bd

• Block toolbar show-icon-label css fixes

  jeryj

  committed
  533f71b

  Copy full SHA for 533f71b

• Top toolbar css fixes

  jeryj

  committed
  a3511a2

  Copy full SHA for a3511a2

• Revert BlockToolbarPopover to mount/unmount instead of show/hide via CSS

  Show description for 2dbc7d9
  jeryj

  committed
  2dbc7d9

  Copy full SHA for 2dbc7d9

• Fix mistake around unlocking PrivateBlockToolbar within same package

  jeryj

  committed
  78fe591

  Copy full SHA for 78fe591

• Update is-typing test to check for toBeHidden and toBeVisible

  jeryj

  committed
  528665a

  Copy full SHA for 528665a

• Remove unused .is-hidden from CSS show/hide toolbar revert

  jeryj

  committed
  d78f373

  Copy full SHA for d78f373

• Refactor to isDefaultEditingMode

  jeryj

  committed
  316de06

  Copy full SHA for 316de06

• Refactor showParentSelector and shouldShowVisualToolbar

  jeryj

  committed
  794bd7e

  Copy full SHA for 794bd7e

• Refactor names and selector return in block tools

  Show description for 0dd53fa
  jeryj

  committed
  0dd53fa

  Copy full SHA for 0dd53fa

• Remove unnecessary flex-shrink from fixed toolbar

  jeryj

  committed
  58afab9

  Copy full SHA for 58afab9