Migrating block inserter media tab components #56195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes `__unstableComposite` imports from `@wordpress/components` - Adds private `Composite*` exports from `@wordpress/components` - Refactors `MediaList` and `MediaPreview` to use updated `Composite` components
andrewhayward
added
[Type] Task
6 tasks
|
Size Change: +64 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
oandregal
added
the
[Type] Code Quality
|
This PR was missing a proper Type label to be used in the changelog of the release. Added Code Quality now. |
ciampo
removed
the
[Type] Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates
MediaListandMediaPreviewin@wordpress/block-editorto use the updatedCompositeimplementation from #54225.Why?
In #54225, an updated implementation of
Compositewas added to@wordpress/components. As per #55224, all consumers ofCompositeneed to migrate from the old version to the new version.How?
__unstableCompositeimports from@wordpress/componentsComposite*exports from@wordpress/componentsMediaListandMediaPreviewto use updatedCompositecomponentsMediaPreviewstructure slightly to remove redundant tab stopsTesting Instructions
Before and after
Testing Instructions for Keyboard