Migrating PatternTransformationsMenu
#56122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes `__unstableComposite` imports from `@wordpress/components` - Adds private `Composite*` exports from `@wordpress/components` - Refactors `BlockPatternsList` and `BlockPattern` to use updated `Composite` components
andrewhayward
added
[Type] Task
6 tasks
|
Size Change: -624 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Nov 15, 2023
| @@ -106,7 +110,6 @@ function BlockPattern( { pattern, onSelect, composite } ) { | |||
| <CompositeItem | |||
| role="option" | |||
| as="div" | |||
There was a problem hiding this comment.
I can see a console warning related to the as prop being deprecated, we should use the render prop instead.
There was a problem hiding this comment.
Good catch – it's a shame this isn't picked up by a linter somewhere.
andrewhayward
deleted the
55224/block-switcher/pattern-transformations-menu
branch
oandregal
added
the
[Type] Code Quality
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
This PR was missing a proper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates
PatternTransformationsMenuin@wordpress/block-editorto use the updatedCompositeimplementation from #54225.Why?
In #54225, an updated implementation of
Compositewas added to@wordpress/components. As per #55224, all consumers ofCompositeneed to migrate from the old version to the new version.How?
__unstableCompositeimports from@wordpress/componentsComposite*exports from@wordpress/componentsBlockPatternsListandBlockPatternto use updatedCompositecomponentsTesting Instructions
Before and after
Testing Instructions for Keyboard