Move clientId key to BlockContextualToolbar #56008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client id was set as a key on the SelectedBlockTools, which helped keep the block to block toolbar connection. This benefit wasn't applied to the BlockContextualToolbar, so fixed toolbars didn't get this bug fix. By moving this key down a level to the BlockContextualToolbar component, all the versions of the toolbar get this bug fix.
jeryj
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the
keyfrom the<SelectedBlockTools />to the<BlockContextualToolbar />Why?
There is a bug where the
<BlockContextualToolbar />loses its connection to the selected block and cannot be focused.How?
The client id was set as a key on the
<SelectedBlockTools />, which helped keep the block to block toolbar connection. This benefit wasn't applied to the<BlockContextualToolbar />, so fixed toolbars didn't get this bug fix. By moving this key down a level to the<BlockContextualToolbar />component, all the versions of the toolbar get this bug fix.Testing Instructions
Repeat the test for all versions of the toolbar - top toolbar, fixed toolbar (smaller screens), and floating popover toolbar. You can also verify on trunk that the above flow is broken for the top toolbar and fixed toolbar.