-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles: More descriptive text for revisions timeline #55868
Styles: More descriptive text for revisions timeline #55868
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sacerro! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
@@ -95,7 +95,7 @@ function ScreenRevisions() { | |||
<ScreenHeader | |||
title={ __( 'Revisions' ) } | |||
description={ __( | |||
'Revisions are added to the timeline when style changes are saved.' | |||
'Restore styles from an earlier version of changes that was automatically added to this timeline when new styles were saved.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The three clauses make it a bit of a mouthful in my opinion.
If we're seeking both clarity and guidance as mentioned in the issue, maybe we could:
- describe what the user is looking at (the clarity)
- provide instruction on how to restore styles (the guidance).
Not being prescriptive, these are just ideas. Language is fuzzy 😄
E.g.,
This is pretty verbose:
Click on previously saved styles to preview them. To restore a selected version to the editor, hit "Apply". When you're ready, save the template to commit your changes.
A bit more condensed:
A timeline of saved changes to your site's styles. Click "Apply" to restore a selected version in the editor.
What do you reckon?
As a heads up, the revisions panel will be getting a UX makeover soon: #55776
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the verbose option is the best. It explains better to the user what this panel do.
What do you think @pablohoneyhoney?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replace the text by the one you suggested 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sacerro wording looks good on the longer option, but the period needs to go inside the quotation mark like so:
Click on previously saved styles to preview them. To restore a selected version to the editor, hit "Apply." When you're ready, save the template to commit your changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @provenself
I've updated the copy to reflect the latest changes.
I'll merge this PR.
Thanks also to @sacerro !
packages/edit-site/src/components/global-styles/screen-revisions/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
packages/edit-site/src/components/global-styles/screen-revisions/index.js
Outdated
Show resolved
Hide resolved
Sorry, I'd set this to auto merge, but I think forgot to approve 🤦🏻 Thanks for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
What?
Fixes #55648. Made in WordCamp Madrid 2023
Why?
Current text needs more context. Proposed text fits better.
How?
Replaced old text by new one proposed.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast