Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content structure initial focus #5573

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Mar 12, 2018

This PR tries to solve the last pending issue from #3216. Initial focus on the "Content Structure" Popover needs to take into account post without any headings.

  • when there are no headings, this Popover has no focusable elements to move focus to
  • when there are headings, focus is currently moved to the first item in the headings tree; however, this way all the previous content (the "counts") is basically "skipped" and screen reader users would have no clue some content exists before the focus

By making the "counts" section a focusable div, with a proper role and aria-label, the first focusable element in this Popover is always the counts section.

A section whose content is parenthetic or ancillary to the main content of the resource.

Seems appropriate to me, can certainly be changed if anyone suggests a better role.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Mar 12, 2018
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good to me. And this tests well 👍 Thank you for working on this improvement @afercia!

@afercia
Copy link
Contributor Author

afercia commented Mar 15, 2018

Thanks @jorgefilipecosta

@afercia afercia merged commit ba7159e into master Mar 15, 2018
@afercia afercia deleted the update/content-structure-initial-focus branch March 15, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants