Divider: migrate from reakit to @ariakit/react

[flootr]

What?

Migrate Divider from reakit to ariakit.

Why?

Part of #53278

As stated in the linked issue Reakit does not explicitly support React 18 (causing peer dependency warnings) and Reakit has already been succeeded by Ariakit, so it will not receive any more updates.

How?

In this case we switch out the Reakit for the Ariakit imports.

Testing Instructions

• There shouldn't be any type errors
• Components unit tests should pass
• Verify the component still looks and works as expected (verify via Storybook)

[ciampo]

It looks like the SeparatorProps from ariakit include the as and render props, which we don't want to expose.

We can easily fix this by adding 'as' and 'render' to the list of omitted props on line 14, but it would be also interesting to know if there;s any particular reason why previously we were not picking up the as prop from SeparatorProps, and now we are.

[flootr]

I applied your suggestions via 7d0b7ce – I'm a bit unsure about the rationale you mentioned.

[ciampo]

Apologies in case I wasn't clear. What I was trying to say is that I was curious to know the reason why previously, when using reakit types, the as prop was not being picked up from SeparatorProps. I guess the answer is simply because SeparatorProps did not include the as prop .

[ciampo]

LGTM 🚀

Looking at Storybook, the last couple of changes that I'd like to propose are to:

• disable controls for the wrapElement prop (ie. setting the control type to null)
• remove the ref prop from the table (since we usually don't list refs as props)

[github-actions]

Flaky tests detected in 9dfeb1b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6771508073
📝 Reported issues:

• [Flaky Test] Overlay menu interactions in Safari (@webkit) #55816 in /test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js
• [Flaky Test] should select with shift + click #48390 in /test/e2e/specs/editor/various/multi-block-selection.spec.js