Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Node 20 #55561

Closed
wants to merge 2 commits into from
Closed

Update to Node 20 #55561

wants to merge 2 commits into from

Conversation

noahtallen
Copy link
Member

@noahtallen noahtallen commented Oct 24, 2023 •
edited
Loading

What?

The current LTS version of Node is now 20. This PR checks how easy it'd be to update, following #53426. This includes npm version 10.

Why?

Node 16 and 18 are no longer LTS.

How?

Testing Instructions

  1. nvm install
  2. verify npm install and build steps work
  3. CI

@noahtallen noahtallen self-assigned this Oct 24, 2023
@noahtallen noahtallen marked this pull request as draft October 24, 2023 09:04
@noahtallen noahtallen mentioned this pull request Oct 24, 2023
Closed
@noahtallen noahtallen added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 24, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2023 •
edited
Loading

Flaky tests detected in b2dbe14.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7105925950
📝 Reported issues:

@flootr flootr mentioned this pull request Nov 27, 2023
Merged
@desrosj
Copy link
Contributor

desrosj commented Dec 5, 2023

Looks like 20.x was just installed on the .org build server. 🎉

Since #56331 has more context and discussion, I'm going to close this out in favor of that one.

@desrosj desrosj closed this Dec 5, 2023
@noahtallen
Copy link
Member Author

noahtallen commented Dec 5, 2023 •
edited
Loading

sounds good!

edit: clicked the wrong button 😆

@noahtallen noahtallen reopened this Dec 5, 2023
@noahtallen noahtallen closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desrosj desrosj Awaiting requested review from desrosj desrosj will be requested when the pull request is marked ready for review desrosj is a code owner

Assignees

@noahtallen noahtallen

Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahtallen @desrosj