Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add align support to the image block #55346

Closed
wants to merge 7 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
new fixtures for the default align attribute of core/image
  • Loading branch information
draganescu committed Nov 6, 2023
commit 19c37f20bed3874bb1a941b12d832408836d05a9
Original file line number Diff line number Diff line change
@@ -19,6 +19,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2016/09/cropped-img_9054-1.jpg?w=190",
"alt": "Image gallery image",
"caption": "",
@@ -32,6 +33,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2017/09/cropped-l1001498-1.jpg?w=580",
"alt": "Image gallery image",
"caption": "",
2 changes: 2 additions & 0 deletions test/integration/fixtures/blocks/core__gallery.json
Original file line number Diff line number Diff line change
@@ -19,6 +19,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2016/09/cropped-img_9054-1.jpg?w=190",
"alt": "Image gallery image",
"caption": "",
@@ -32,6 +33,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2017/09/cropped-l1001498-1.jpg?w=580",
"alt": "Image gallery image",
"caption": "",
2 changes: 2 additions & 0 deletions test/integration/fixtures/blocks/core__gallery__columns.json
Original file line number Diff line number Diff line change
@@ -19,6 +19,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2016/09/cropped-img_9054-1.jpg?w=190",
"alt": "Image gallery image",
"caption": "",
@@ -32,6 +33,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2017/09/cropped-l1001498-1.jpg?w=580",
"alt": "Image gallery image",
"caption": "",
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "title",
"linkDestination": "none"
@@ -24,6 +25,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/jpeg;base64,/9j/2wBDAAMCAgICAgMCAgIDAwMDBAYEBAQEBAgGBgUGCQgKCgkICQkKDA8MCgsOCwkJDRENDg8QEBEQCgwSExIQEw8QEBD/yQALCAABAAEBAREA/8wABgAQEAX/2gAIAQEAAD8A0s8g/9k=",
"alt": "title",
"linkDestination": "none"
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "title",
"caption": "",
@@ -26,6 +27,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/jpeg;base64,/9j/2wBDAAMCAgICAgMCAgIDAwMDBAYEBAQEBAgGBgUGCQgKCgkICQkKDA8MCgsOCwkJDRENDg8QEBEQCgwSExIQEw8QEBD/yQALCAABAAEBAREA/8wABgAQEAX/2gAIAQEAAD8A0s8g/9k=",
"alt": "title",
"caption": "",
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "title",
"caption": "",
@@ -24,6 +25,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/jpeg;base64,/9j/2wBDAAMCAgICAgMCAgIDAwMDBAYEBAQEBAgGBgUGCQgKCgkICQkKDA8MCgsOCwkJDRENDg8QEBEQCgwSExIQEw8QEBD/yQALCAABAAEBAREA/8wABgAQEAX/2gAIAQEAAD8A0s8g/9k=",
"alt": "title",
"caption": "",
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2016/09/cropped-img_9054-1.jpg?w=190",
"alt": "",
"caption": "",
@@ -26,6 +27,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2017/09/cropped-l1001498-1.jpg?w=580",
"alt": "",
"caption": "",
@@ -38,6 +40,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "https://sergioestevaofolio.files.wordpress.com/2017/05/cropped-l1005945-2-2.jpg?w=580",
"alt": "",
"caption": "",
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/09/test-image-edited-1-682x1024.jpg",
"alt": "",
"caption": "",
@@ -28,6 +29,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/09/test-image-edited-1024x682.jpg",
"alt": "",
"caption": "",
@@ -42,6 +44,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/04/test-image-1024x683.jpg",
"alt": "",
"caption": "",
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/09/test-image-edited-1-682x1024.jpg",
"alt": "",
"caption": "",
@@ -28,6 +29,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/09/test-image-edited-1024x682.jpg",
"alt": "",
"caption": "",
@@ -42,6 +44,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/04/test-image-1024x683.jpg",
"alt": "",
"caption": "",
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/09/test-image-edited-1-682x1024.jpg",
"alt": "",
"caption": "",
@@ -32,6 +33,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/09/test-image-edited-1024x682.jpg",
"alt": "",
"caption": "",
@@ -46,6 +48,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/04/test-image-1024x683.jpg",
"alt": "",
"caption": "",
@@ -77,6 +80,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/09/test-image-edited-1-682x1024.jpg",
"alt": "",
"caption": "",
@@ -91,6 +95,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/09/test-image-edited-1024x682.jpg",
"alt": "",
"caption": "",
@@ -105,6 +110,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "http://wptest.local/wp-content/uploads/2020/04/test-image-1024x683.jpg",
"alt": "",
"caption": "",
1 change: 1 addition & 0 deletions test/integration/fixtures/blocks/core__image.json
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "",
"caption": ""
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "",
"caption": "",
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "",
"caption": "",
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "",
"caption": "",
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "",
"caption": "",
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@
"name": "core/image",
"isValid": true,
"attributes": {
"align": "",
"url": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==",
"alt": "",
"caption": "",
Loading