Consistent default typography controls across blocks #55208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Package] Block library
richtabor
changed the title
|
Pending @WordPress/gutenberg-design review, I'd appreciate help on the tests. |
|
This makes sense to me, however I'd be a little wary about merging given the logic about which controls to display might also be affected by #49278. Would this be too confusing? |
I think it helps if we have consistent default views across the board. Then if a default value is applied from Global Styles, then those should be reflected in the UI. |
|
Yes I suppose this change moves us in the right general direction by displaying fewer controls that have no locally assigned value. |
jameskoster
approved these changes
Oct 18, 2023
|
@Mamaduka Any chance you could help with the tests here? 🙇♂️ |
Mamaduka
force-pushed
the
tweak/consistent-text-default-controls
branch
from
d947eba
to
86e3496
Compare
Mamaduka
approved these changes
Nov 29, 2023
|
Size Change: -65 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adjust the default controls across typography blocks to ensure they are consistent experience across the editor.
How?
Adjusting block.json for each.
Testing Instructions
Screenshots or screencast