-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong notification message shown when an entity is moved to trash #55155
Conversation
Size Change: +9 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Nik!
It works well in my test ✅
Flaky tests detected in 76e8066. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6454671285
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks for the fix 🚀
@ntsekouras, feel free to ignore failing Cover block test. It's flaky. |
What?
Fixes: #19144
When moving a post to
trash
from the Document settings panel, the notification message after successful completion of operation is that the post has been reverted to draft. This PR uses the new labels added in [6.3] (https://core.trac.wordpress.org/changeset/55923) and shows the proper message.Noting that in the redirect to the main list happens quite quickly and in order to view the snackbar, we need slow internet connection. You can use the devtools for that.
Testing Instructions