Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 16:10 from 10:16 options from AspectRatioDropdown #55053

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Remove 16:10 from 10:16 options from AspectRatioDropdown #55053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82ad733
Remove 16:10/10:16
richtabor Oct 4, 2023
723c0e2
Update image.spec.js
richtabor Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/block-editor/src/components/image-editor/aspect-ratio-dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ export default function AspectRatioDropdown( { toggleProps } ) {
} }
value={ aspect }
aspectRatios={ [
{
title: __( '16:10' ),
aspect: 16 / 10,
},
{
title: __( '16:9' ),
aspect: 16 / 9,
Expand All @@ -101,10 +97,6 @@ export default function AspectRatioDropdown( { toggleProps } ) {
} }
value={ aspect }
aspectRatios={ [
{
title: __( '10:16' ),
aspect: 10 / 16,
},
{
title: __( '9:16' ),
aspect: 9 / 16,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/blocks/image.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ test.describe( 'Image', () => {
await editor.clickBlockToolbarButton( 'Crop' );
await editor.clickBlockToolbarButton( 'Aspect Ratio' );
await page.click(
'role=menu[name="Aspect Ratio"i] >> role=menuitemradio[name="16:10"i]'
'role=menu[name="Aspect Ratio"i] >> role=menuitemradio[name="16:9"i]'
);
await editor.clickBlockToolbarButton( 'Apply' );

Expand Down
Loading