-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a broken MD link in callout #54772
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @leemyongpakvn! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I have encountered a similar problem with #50437 etc 😄 I've left some comments, so I'd be happy if you could check them out.
docs/how-to-guides/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
…e.md Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for updating 👍
Congratulations on your first merged pull request, @leemyongpakvn! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
@leemyongpakvn note that we're compiling credits for the WordPress 6.5 release and would like to confirm your WordPress.org username so that you're properly included in the credits. Mind responding / linking your GH.com and WP.org accounts as noted by the bot comment above? |
What?
MarkDown link broken in callout div. Use pure HTML link to solve it.
Why?
How?
Testing Instructions
Use MD editor Preview or Open https://developer.wordpress.org/block-editor/how-to-guides/block-tutorial/writing-your-first-block-type/ to see how MD link broken.
Testing Instructions for Keyboard
Screenshots or screencast