Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken MD link in callout #54772

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Fix a broken MD link in callout #54772

merged 4 commits into from
Sep 25, 2023

Conversation

leemyongpakvn
Copy link
Contributor

What?

MarkDown link broken in callout div. Use pure HTML link to solve it.

Why?

How?

Testing Instructions

Use MD editor Preview or Open https://developer.wordpress.org/block-editor/how-to-guides/block-tutorial/writing-your-first-block-type/ to see how MD link broken.

Testing Instructions for Keyboard

Screenshots or screencast

MD_link_broken_in_Callout

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 25, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @leemyongpakvn! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Sep 25, 2023
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I have encountered a similar problem with #50437 etc 😄 I've left some comments, so I'd be happy if you could check them out.

packages/components/README.md Outdated Show resolved Hide resolved
leemyongpakvn and others added 2 commits September 25, 2023 16:46
…e.md

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@leemyongpakvn leemyongpakvn changed the title Fix a broken MD link in callout and a typo Fix a broken MD link in callout Sep 25, 2023
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for updating 👍

@t-hamano t-hamano merged commit d3ceb5e into WordPress:trunk Sep 25, 2023
@github-actions
Copy link

Congratulations on your first merged pull request, @leemyongpakvn! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@jeffpaul
Copy link
Member

@leemyongpakvn note that we're compiling credits for the WordPress 6.5 release and would like to confirm your WordPress.org username so that you're properly included in the credits. Mind responding / linking your GH.com and WP.org accounts as noted by the bot comment above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants