List View: Hack back in a border color for the list view drop indicator #54712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Feature] List View
|
Size Change: +131 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
You know, in my quick testing, this isn't terrible! |
|
Just closing this PR out now as it's no longer needed since we now displace list view items as of #56625. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #52917
🚧 🚧 🚧 WIP: I'm not sold on this approach, this PR exists for demonstration purposes 🚧 🚧 🚧
Hack back in the border for the list view drop indicator line.
Why?
As described in #52917, the visibility of the drop indicator line can be an issue when blocks are selected.
How?
Try hacking the border back in there, and overriding the border color in dark mode via injecting a classname for the drop indicator line.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast