Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Face: Get name from "fontFamily" setting, not "name". #54615

Merged
merged 9 commits into from
Sep 22, 2023

Commits on Sep 19, 2023

  1. Gets name from fontFamily as fallback check.

    If the "name" setting does not exist, then get it from the "fontFamily" setting.
    hellofromtonya committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5689b53 View commit details
    Browse the repository at this point in the history
  2. Move tests into existing test.

    To avoid reflection issues on different PHP versions and
    potential contributor confusion, merging the new tests into
    the existing test.
    hellofromtonya committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    370caf0 View commit details
    Browse the repository at this point in the history
  3. Do not use "name".

    Do not the "name" settting. Instead only use the required "fontFamily" setting.
    hellofromtonya committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1c1b96e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. trim quotes on font family name

    Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com>
    matiasbenedetto and ironprogrammer committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8483b7f View commit details
    Browse the repository at this point in the history
  2. making sure the name value differs from fontFamily to validate that t…

    …he former is not being used
    
    Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com>
    matiasbenedetto and ironprogrammer committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e0f88c0 View commit details
    Browse the repository at this point in the history
  3. validate trimming changes

    Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com>
    matiasbenedetto and ironprogrammer committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    60a5a50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    014b4e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Configuration menu
    Copy the full SHA
    084e83d View commit details
    Browse the repository at this point in the history
  2. Remove test temporarily

    Because `WP_Font_Face_Resolver` already exists in Core release code, this update cannot be tested in CI without migrating the code into a temporary `_Gutenberg` resolver, which will complicate syncing back to Core.
    
    Test will be added to a follow-up PR, to merge once this update is synced to Core.
    
    Note that this test does succeed when run locally against WP `trunk` (currently 6.4-alpha).
    ironprogrammer committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    29df9f8 View commit details
    Browse the repository at this point in the history