Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add ability to target Nav block current menu item via Theme JSON #54460

Draft
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Draft

[WIP] Add ability to target Nav block current menu item via Theme JSON #54460

wants to merge 10 commits into from
+73 −8

Commits on Feb 12, 2024

  1. HACK: Add ability to filter tests

    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    73109c1 View commit details
    Browse the repository at this point in the history

  2. Add initial test coverage

    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    f61744f View commit details
    Browse the repository at this point in the history

  3. Move to green

    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b910345 View commit details
    Browse the repository at this point in the history

  4. Iterate towards selectors api

    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3a020b0 View commit details
    Browse the repository at this point in the history

  5. Pass correct feature node to compute style properties for feature sel… 

    …ector
    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    d5bc93e View commit details
    Browse the repository at this point in the history

  6. Improve comment

    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    ca3715c View commit details
    Browse the repository at this point in the history

  7. Simplify test assertion readability in output by stripping base styles

    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    1cfd089 View commit details
    Browse the repository at this point in the history

  8. Dynamically fetch the classname used for the currentItem

    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    60b8833 View commit details
    Browse the repository at this point in the history

  9. Conform to Selectors API and put more onus on block author

    @getdave @scruffian
    getdave authored and scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    57714c1 View commit details
    Browse the repository at this point in the history

  10. PHPCS fix

    @scruffian
    scruffian committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e255506 View commit details
    Browse the repository at this point in the history