-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow accessing the patterns screen when the classic theme supports block-template-parts
#54342
Closed
kevin940726
wants to merge
2
commits into
trunk
from
fix/allow-patterns-access-for-block-template-parts
Closed
Allow accessing the patterns screen when the classic theme supports block-template-parts
#54342
kevin940726
wants to merge
2
commits into
trunk
from
fix/allow-patterns-access-for-block-template-parts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block-template-parts'
Size Change: -50 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
We're going with #54066. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
[Type] WP Core Ticket
Requires an upstream change from WordPress. Core Trac ticket should be linked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An alternative to #54066 which implements the approach in #54066 (review).
Why?
See #52150.
How?
For classic themes: "Manage patterns" points to
edit.php?post_type=wp_block
. Add aPatterns
link under the Appearance section that points toedit.php?post_type=wp_block
as well.For classic themes with
block-template-parts
support: "Manage patterns" points tosite-editor.php?path=/patterns
. Add aPatterns
link under the Appearance section that points tosite-editor.php?path=/patterns
as well.For block themes: "Manage patterns" points to
site-editor.php?path=/patterns
.Testing Instructions
This PR requires WordPress/wordpress-develop@trunk...kevin940726:wordpress-develop:fix/allow-patterns-access-for-block-template-parts. Please apply the diff in core before testing.
There are multiple places that we can link to the patterns page:
patterns
and hit Enter.For classic themes without
block-template-parts
support (liketwentytwentyone
):edit.php?post_type=wp_block
.edit.php?post_type=wp_block
.For classic themes with
block-template-parts
support (likeemptyhybrid
):site-editor.php?path=/patterns
.site-editor.php?path=/patterns
.For block themes:
site-editor.php?path=/patterns
.Testing Instructions for Keyboard
Same as above.
Screenshots or screencast
TBD