Interactivity API: Update data-wp-bind directive logic
#54003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +61 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
DAreRodz
added
[Feature] Interactivity API
DAreRodz
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
20 tasks
DAreRodz
changed the title
data-wp-bind directive logic
SantosGuillamot
approved these changes
Aug 29, 2023
This should be done in a separate PR.
DAreRodz
force-pushed
the
update/interactivity-api-bind-directive-logic
branch
from
e06b9d8 to
23489d5
Compare
21 tasks
|
Great work. I didn't know that |
|
By the way, @DAreRodz, this should have been an "Enhancement", not a feature 🙂 |
Oops, my fault. 🙈 It was fine in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the logic of
data-wp-bindto match Preact's logic during hydration.Why?
Required by #53737, see #53737 (comment))
How?
We copied Preact's code (link) into the
useEffecthook used to initialize bound values and added e2e tests to cover several representative cases.Note that, most of the time, Preact modifies the
HTMLElementinstance properties instead of the attributes, so the final values vary depending on the modified property. In some cases, attributes may not even change at all.Testing Instructions
E2E tests should pass.