Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] - Fix Voice Over and assistive keyboards #53895

Merged
merged 4 commits into from
Aug 24, 2023
Merged

[Mobile] - Fix Voice Over and assistive keyboards #53895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a491eb
AztecView - Replace usage of TouchableWithoutFeedback with Pressable …
Aug 23, 2023
c5f4583
Patch React Native's TextInput component to avoid passing the recentl…
Aug 23, 2023
ce4c59b
Updates snapshots: Fule, Audio blocks and Search component after chan…
Aug 23, 2023
8d711e6
Update AztecView's Pressable with changing its accessible prop to false
Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 106 additions & 78 deletions packages/block-library/src/audio/test/__snapshots__/edit.native.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ exports[`Audio block renders audio block error state without crashing 1`] = `
]
}
>
<RCTAztecView
<View
accessibilityState={
{
"busy": undefined,
Expand All @@ -143,59 +143,73 @@ exports[`Audio block renders audio block error state without crashing 1`] = `
"selected": undefined,
}
}
accessible={true}
activeFormats={[]}
blockType={
accessibilityValue={
{
"tag": "p",
"max": undefined,
"min": undefined,
"now": undefined,
"text": undefined,
}
}
deleteEnter={true}
disableEditingMenu={false}
accessible={false}
collapsable={false}
focusable={true}
fontFamily="serif"
fontSize={14}
isMultiline={false}
maxImagesWidth={200}
onBackspace={[Function]}
onBlur={[Function]}
onChange={[Function]}
onClick={[Function]}
onContentSizeChange={[Function]}
onEnter={[Function]}
onFocus={[Function]}
onHTMLContentWithCursor={[Function]}
onKeyDown={[Function]}
onPaste={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
onResponderTerminate={[Function]}
onResponderTerminationRequest={[Function]}
onSelectionChange={[Function]}
onStartShouldSetResponder={[Function]}
placeholder="Add caption"
placeholderTextColor="gray"
selectionColor="black"
style={
{
"backgroundColor": undefined,
"maxWidth": undefined,
"minHeight": 0,
>
<RCTAztecView
activeFormats={[]}
blockType={
{
"tag": "p",
}
}
}
text={
{
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"tag": "p",
"text": "",
deleteEnter={true}
disableEditingMenu={false}
fontFamily="serif"
fontSize={14}
isMultiline={false}
maxImagesWidth={200}
onBackspace={[Function]}
onBlur={[Function]}
onChange={[Function]}
onContentSizeChange={[Function]}
onEnter={[Function]}
onFocus={[Function]}
onHTMLContentWithCursor={[Function]}
onKeyDown={[Function]}
onPaste={[Function]}
onSelectionChange={[Function]}
placeholder="Add caption"
placeholderTextColor="gray"
selectionColor="black"
style={
{
"backgroundColor": undefined,
"maxWidth": undefined,
"minHeight": 0,
}
}
}
textAlign="center"
triggerKeyCodes={[]}
/>
text={
{
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"tag": "p",
"text": "",
}
}
textAlign="center"
triggerKeyCodes={[]}
/>
</View>
</View>
</View>
</View>
Expand Down Expand Up @@ -359,7 +373,7 @@ exports[`Audio block renders audio file without crashing 1`] = `
]
}
>
<RCTAztecView
<View
accessibilityState={
{
"busy": undefined,
Expand All @@ -369,59 +383,73 @@ exports[`Audio block renders audio file without crashing 1`] = `
"selected": undefined,
}
}
accessible={true}
activeFormats={[]}
blockType={
accessibilityValue={
{
"tag": "p",
"max": undefined,
"min": undefined,
"now": undefined,
"text": undefined,
}
}
deleteEnter={true}
disableEditingMenu={false}
accessible={false}
collapsable={false}
focusable={true}
fontFamily="serif"
fontSize={14}
isMultiline={false}
maxImagesWidth={200}
onBackspace={[Function]}
onBlur={[Function]}
onChange={[Function]}
onClick={[Function]}
onContentSizeChange={[Function]}
onEnter={[Function]}
onFocus={[Function]}
onHTMLContentWithCursor={[Function]}
onKeyDown={[Function]}
onPaste={[Function]}
onResponderGrant={[Function]}
onResponderMove={[Function]}
onResponderRelease={[Function]}
onResponderTerminate={[Function]}
onResponderTerminationRequest={[Function]}
onSelectionChange={[Function]}
onStartShouldSetResponder={[Function]}
placeholder="Add caption"
placeholderTextColor="gray"
selectionColor="black"
style={
{
"backgroundColor": undefined,
"maxWidth": undefined,
"minHeight": 0,
>
<RCTAztecView
activeFormats={[]}
blockType={
{
"tag": "p",
}
}
}
text={
{
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"tag": "p",
"text": "",
deleteEnter={true}
disableEditingMenu={false}
fontFamily="serif"
fontSize={14}
isMultiline={false}
maxImagesWidth={200}
onBackspace={[Function]}
onBlur={[Function]}
onChange={[Function]}
onContentSizeChange={[Function]}
onEnter={[Function]}
onFocus={[Function]}
onHTMLContentWithCursor={[Function]}
onKeyDown={[Function]}
onPaste={[Function]}
onSelectionChange={[Function]}
placeholder="Add caption"
placeholderTextColor="gray"
selectionColor="black"
style={
{
"backgroundColor": undefined,
"maxWidth": undefined,
"minHeight": 0,
}
}
}
textAlign="center"
triggerKeyCodes={[]}
/>
text={
{
"eventCount": undefined,
"linkTextColor": undefined,
"selection": null,
"tag": "p",
"text": "",
}
}
textAlign="center"
triggerKeyCodes={[]}
/>
</View>
</View>
</View>
</View>
Expand Down
Loading