Modal
: make everything outside inert
#53829
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bug fix/enhancement to
Modal
component.Why?
I think
inert
is what we'd have used from the get go had it been well supported then.To fix #41503
This should also help with other obscure problems like one that can be triggered by undo/redo keyboard shortcuts while a Modal is open.
How?
Updates use of
aria-hidden
toinert
.Testing Instructions