Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Tests: Separate page setup from test #53808

Merged
merged 18 commits into from
Sep 21, 2023
Merged

Performance Tests: Separate page setup from test #53808

merged 18 commits into from
Sep 21, 2023

Commits on Aug 18, 2023

  1. Utilize the new context created internally 

    ...instead of manually creating a new one. This is good practice as it allows us to utilize the Playwright fixtures for each page that is created, which is not possible when creating contexts manually. It also improves consistency as it ensures each page is created with the same initial params.
    @WunderBart
    WunderBart committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    d9be785 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Merge remote-tracking branch 'origin' into refactor/perf-use-test-con… 

    …text
    @WunderBart
    WunderBart committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    80bd98d View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary waiter

    @WunderBart
    WunderBart committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    59be4bc View commit details
    Browse the repository at this point in the history

  3. Add more consistency

    @WunderBart
    WunderBart committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    954270a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Merge remote-tracking branch 'origin' into refactor/perf-use-test-con… 

    …text
    @WunderBart
    WunderBart committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a5778c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Merge remote-tracking branch 'origin' into refactor/perf-use-test-con… 

    …text
    @WunderBart
    WunderBart committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    cb3505f View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Isolate page setup from test + abstract fixtures

    @WunderBart
    WunderBart committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    e49ce6b View commit details
    Browse the repository at this point in the history

  2. We're only waiting for the first block to be available 

    It might still be covered by the loading overlay, which doesn't mean it's not available, which is what we're interested in.
    @WunderBart
    WunderBart committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    cc8158a View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Make the metrics fixture context-agnostic

    @WunderBart
    WunderBart committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    7000dec View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Merge remote-tracking branch 'origin' into refactor/perf-use-test-con… 

    …text
    @WunderBart
    WunderBart committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    26c93df View commit details
    Browse the repository at this point in the history

  2. Make sample iteration consistent

    @WunderBart
    WunderBart committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    55c071b View commit details
    Browse the repository at this point in the history

  3. Merge with the Metrics e2e fixture

    @WunderBart
    WunderBart committed Sep 20, 2023
    1 Configuration menu
    Copy the full SHA
    1b00741 View commit details
    Browse the repository at this point in the history

  4. Define Trace interface

    @WunderBart
    WunderBart committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    693caec View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Avoid unnecessart type casting

    @WunderBart
    WunderBart committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    33a78eb View commit details
    Browse the repository at this point in the history

  2. Assert non-null instead of casting

    @WunderBart
    WunderBart committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    feb23d5 View commit details
    Browse the repository at this point in the history

  3. Migrate PerfUtils to TS

    @WunderBart
    WunderBart committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5c67b2d View commit details
    Browse the repository at this point in the history

  4. Revert some unwanted removals

    @WunderBart
    WunderBart committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    71a1d58 View commit details
    Browse the repository at this point in the history

  5. Improve jsdoc consistency

    @WunderBart
    WunderBart committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d12b20d View commit details
    Browse the repository at this point in the history