Inject theme stylesheet value as template part theme attribute #53423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +99 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
pbking
added
[Type] Enhancement
mikachan
added
[Package] Block library
mikachan
reviewed
Aug 14, 2023
There was a problem hiding this comment.
Thanks for working on this!
This fix only seems to work if the template part is in the root of the pattern, i.e. not inside another block such as a group or cover block.
I tested this using Overlaid and Lativ, which I've seen this issue with previously in their home.html templates. Both of their header template parts are inside other blocks within the pattern, and I'm still seeing the 'Template part has been deleted' message:
I think we also need to check the innerBlocks of each block for template parts too. I've left a potential fix in the inline comments.
Otherwise, this is ace. It'll be so great to fix this!
mikachan
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Nice, looking good! This fixes the issue in Lativ:
(Excuse my ugly menu.)
Looks like this PR needs to be updated with the latest from trunk or rebased, as I believe the failing automated tests are related to the Node upgrade. Once that's done I think it'll be ready to bring in 🎉
pbking
force-pushed
the
fix/53194-render-template-part-in-pattern-without-theme-attribute
branch
from
cb99cfe to
726b1e2
Compare
mikachan
approved these changes
Aug 15, 2023
pbking
deleted the
fix/53194-render-template-part-in-pattern-without-theme-attribute
branch
|
We are exploring an alternative approach for this solution because the changes on the server seem to have a negative impact on the performance. We are thinking about the following approach: #55217. How we can validate it works as intended? One open question is whether the Pattern returned from REST API needs to have the current theme injected as the |
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #53194
When a Template Part is included in a Pattern the Template Part must have a
themeattribute else the template part does not render. This is different from including a template part in a template (or another template part) since, in those situations, thethemeattribute is assumed to be "the current theme".This change replicates that behavior in patterns so that Template Parts referenced from them is assumed to be "the current theme".
Why?
In some design scenarios it's necessary to include content in a pattern (so that the content can be localized, or media references can be included) in such a way that things such as headers and footers contained in template parts need to be included. This change allows that.
How?
When templates are being rendered (both as a view and in the editor) if a template block is being rendered and it is missing the
themeattribute the current theme's 'stylesheet' property is set as the value.Testing Instructions
Activate a theme with a TEMPLATE that references a PATTERN.
<!-- wp:pattern {"slug":"blank/pattern-with-part"} /-->The PATTERN should reference a TEMPLATE PART.
And the template part should have content:
Before this patch is applied 'The template part cannot be found' is shown to the user in the editor and view.
After this patch is applied the template part is rendered as expected.