Dependencies: Bump remove-accents to 0.5.0
#53420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: +1.27 kB (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7592184. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5820766838
|
Mamaduka
reviewed
Aug 8, 2023
|
Thanks @Mamaduka 🙌
I think this is an improvement in any case and the unit test confirms it. For the protocol, I'm happy to do further improvements on the WDYT? |
Mamaduka
approved these changes
Aug 8, 2023
tyxla
force-pushed
the
bump/remove-accents-0.5.0
branch
from
09218c5 to
3608ca0
Compare
|
2 days later, I'll be shipping and will be keeping an eye on reports for bugs or additional character support. Thanks again for taking a look @Mamaduka 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR bumps
remove-accentsto v0.5.0.Fixes #12907, which from what I understand is open because of the lack of proper Vietnamese support.
Why?
Because it's the latest version, it resolves a few issues, namely some discrepancies with Vietnamese and Cyrillic.
How?
I'm bumping the package version and adding a unit test that confirms the changes work as expected.
Testing Instructions
Verify Gutenberg builds and runs well, tests pass and all checks are green (I'm intentionally not adding a components package CHANGELOG entry).
Testing Instructions for Keyboard
None
Screenshots or screencast
None