Remove duplicated display URL in LinkControl #53167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
Size Change: -173 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 233b22e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5715718487
|
|
It works, but I'm not seeing the truncation: 
How useful do y'all think the link is here? I'm likely missing something but it doesn't really seem worth including to me, given the image is already visible. One other tiny detail—the text isn't aligned with the icon along the X axis: 
|
This is probably because the image extension is |
I noticed that and in general we need some polishing there(for example this line is an improvement to trunk). We could probably align them better if we conditionally applied flex-start/center here, depending of one lines vs two lines. |
|
I don't know that it needs to be conditional. If the line-height of the |
I updated that. Make sure you test a link control with two lines(when the url is not the same with the title), if it feels okay or we need to make adjustments there too. |
|
I think it's fine, if we also remove the 
Might be best to keep further polish to a separate PR. |
|
Anything else to do here? I'll be AFK next week and would love to wrap this up. Thanks! |
mikachan
added
the
[Feature] Link Editing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #53143
In Link Control component do not render the URL if it's the same with the displayed title.
Before
After